Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: Improve the responsiveness of some symbol tree widgets #11813

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

chaoticgd
Copy link
Contributor

Description of Changes

This fixes two minor issues with the symbol trees:

  • When you click a checkbox in the symbol tree (displayed for bools) it will now write the new value back to memory immediately instead of waiting for you to deselect the checkbox.
  • When you reset the children of a symbol tree node it will now populate their values from memory immediately instead of waiting for them to update. This prevents flicker.

Rationale behind Changes

It makes the check box widgets delightful to use.

Suggested Testing Steps

  • Create a global variable of type bool for some variable where the result is immediately apparent on screen, and check and uncheck the box repeatedly until you're satisfied that the new behaviour is better.
  • Now make an array and click the "Reset Children" context menu option on it, and observe that the children don't flicker.

@F0bes F0bes merged commit 8d3f4fa into PCSX2:master Sep 15, 2024
12 checks passed
@chaoticgd chaoticgd deleted the check_box_bug branch September 20, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants